ruler: Make alertmanager client and all related config per-tenant configurable #10816
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -966,7 +966,7 @@ func (t *Mimir) initRuler() (serv services.Service, err error) { | |
| ) | ||
|
|
||
| dnsResolver := dns.NewProvider(util_log.Logger, dnsProviderReg, dns.GolangResolverType) | ||
| manager, err := ruler.NewDefaultMultiTenantManager(t.Cfg.Ruler, managerFactory, t.Registerer, util_log.Logger, dnsResolver, t.Overrides) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ import ( | |
| "github.com/grafana/mimir/pkg/mimirpb" | ||
| "github.com/grafana/mimir/pkg/querier" | ||
| querier_stats "github.com/grafana/mimir/pkg/querier/stats" | ||
| notifierCfg "github.com/grafana/mimir/pkg/ruler/notifier" | ||
| util_log "github.com/grafana/mimir/pkg/util/log" | ||
| ) | ||
|
|
||
|
|
@@ -213,6 +214,7 @@ type RulesLimits interface { | |
| RulerSyncRulesOnChangesEnabled(userID string) bool | ||
| RulerProtectedNamespaces(userID string) []string | ||
| RulerMaxIndependentRuleEvaluationConcurrencyPerTenant(userID string) int64 | ||
| RulerAlertmanagerClientConfig(userID string) notifierCfg.AlertmanagerClientConfig | ||
| } | ||
|
|
||
| func MetricsQueryFunc(qf rules.QueryFunc, userID string, queries, failedQueries *prometheus.CounterVec, remoteQuerier bool) rules.QueryFunc { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,9 @@ type DefaultMultiTenantManager struct { | |
| cfg Config | ||
| notifierCfg *config.Config | ||
| managerFactory ManagerFactory | ||
| limits RulesLimits | ||
| dnsResolver AddressProvider | ||
| refreshMetrics discovery.RefreshMetricsManager | ||
|
|
||
| mapper *mapper | ||
|
|
||
|
|
@@ -59,9 +62,9 @@ type DefaultMultiTenantManager struct { | |
| rulerIsRunning atomic.Bool | ||
| } | ||
|
|
||
| func NewDefaultMultiTenantManager(cfg Config, managerFactory ManagerFactory, reg prometheus.Registerer, logger log.Logger, dnsResolver AddressProvider, limits RulesLimits) (*DefaultMultiTenantManager, error) { | ||
| refreshMetrics := discovery.NewRefreshMetrics(reg) | ||
| ncfg, err := buildNotifierConfig(cfg.AlertmanagerURL, cfg.Notifier, cfg, dnsResolver, refreshMetrics) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
@@ -75,6 +78,9 @@ func NewDefaultMultiTenantManager(cfg Config, managerFactory ManagerFactory, reg | |
| cfg: cfg, | ||
| notifierCfg: ncfg, | ||
| managerFactory: managerFactory, | ||
| limits: limits, | ||
| dnsResolver: dnsResolver, | ||
| refreshMetrics: refreshMetrics, | ||
| notifiers: map[string]*rulerNotifier{}, | ||
| mapper: newMapper(cfg.RulePath, logger), | ||
| userManagers: map[string]RulesManager{}, | ||
|
|
@@ -321,8 +327,17 @@ func (r *DefaultMultiTenantManager) getOrCreateNotifier(userID string) (*notifie | |
|
|
||
| n.run() | ||
|
|
||
| notifierCfg := r.notifierCfg | ||
| userSpecificCfg := r.limits.RulerAlertmanagerClientConfig(userID) | ||
| if !userSpecificCfg.IsDefault() { | ||
| notifierCfg, err = buildNotifierConfig(userSpecificCfg.AlertmanagerURL, userSpecificCfg.NotifierConfig, r.cfg, r.dnsResolver, r.refreshMetrics) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
|
|
||
| // This should never fail, unless there's a programming mistake. | ||
| if err := n.applyConfig(notifierCfg); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.