Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky query-frontend integration tests after #10798 #10818

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Mar 6, 2025

What this PR does

Following the changes in #10798, query-frontend integration tests can fail with:

    query_frontend_test.go:375: 
        	Error Trace:	/home/runner/work/mimir/mimir/integration/query_frontend_test.go:375
        	            				/home/runner/work/mimir/mimir/integration/query_frontend_test.go:49
        	Error:      	Received unexpected error:
        	            	unable to find metrics [cortex_frontend_split_queries_total] with expected values. Last error: <nil>. Last values: [32]
        	Test:       	TestQueryFrontendWithBlocksStorageViaFlags

This happens when the test is being run between 00:00 and 01:00 UTC, as then the query touches data in 32 different days and so is split 32 ways.

⚠️ This PR depends on grafana/e2e#20.

Which issue(s) this PR fixes or relates to

#10798

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review March 6, 2025 01:43
@charleskorn charleskorn requested review from stevesg, grafanabot and a team as code owners March 6, 2025 01:43
@charleskorn charleskorn enabled auto-merge (squash) March 6, 2025 03:11
@charleskorn charleskorn force-pushed the charleskorn/fix-flaky-test branch from df6a851 to c4a3be8 Compare March 6, 2025 03:23
@charleskorn charleskorn merged commit 339171c into main Mar 6, 2025
28 checks passed
@charleskorn charleskorn deleted the charleskorn/fix-flaky-test branch March 6, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants