Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: Add req/sec floor to MimirCacheRequestErrors #10832

Merged
merged 1 commit into from
Mar 7, 2025
+8 −6
Merged

mixin: Add req/sec floor to MimirCacheRequestErrors #10832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@

### Mixin

* [CHANGE] Alerts: Only alert on errors performing cache operations if there are over 10 request/sec to avoid flapping. #10832
* [FEATURE] Add compiled mixin for GEM installations in `operations/mimir-mixin-compiled-gem`. #10690
* [ENHANCEMENT] Dashboards: clarify that the ingester and store-gateway panels on the 'Reads' dashboard show data from all query requests to that component, not just requests from the main query path (ie. requests from the ruler query path are included as well). #10598
* [ENHANCEMENT] Dashboards: add ingester and store-gateway panels from the 'Reads' dashboard to the 'Remote ruler reads' dashboard as well. #10598
Expand Down
2 changes: 1 addition & 1 deletion ...amonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ spec:
/
sum by(cluster, namespace, name, operation) (
rate(thanos_cache_operations_total{operation!~"add|delete"}[1m])
)
) > 10
) * 100 > 5
for: 5m
labels:
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled-baremetal/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ groups:
/
sum by(cluster, namespace, name, operation) (
rate(thanos_cache_operations_total{operation!~"add|delete"}[1m])
)
) > 10
) * 100 > 5
for: 5m
labels:
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled-gem/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ groups:
/
sum by(cluster, namespace, name, operation) (
rate(thanos_cache_operations_total{operation!~"add|delete"}[1m])
)
) > 10
) * 100 > 5
for: 5m
labels:
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ groups:
/
sum by(cluster, namespace, name, operation) (
rate(thanos_cache_operations_total{operation!~"add|delete"}[1m])
)
) > 10
) * 100 > 5
for: 5m
labels:
Expand Down
5 changes: 3 additions & 2 deletions operations/mimir-mixin/alerts/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,8 @@ local utils = import 'mixin-utils/utils.libsonnet';
alert: $.alertName('CacheRequestErrors'),
// Specifically exclude "add" and "delete" operations which are used for cache invalidation and "locking"
// since they are expected to sometimes fail in normal operation (such as when a "lock" already exists or
// key being invalidated does not exist).
// key being invalidated does not exist). We also only alert when there at least 10 req/sec to the cache
// to avoid flapping alerts in low-traffic environments.
expr: |||
(
sum by(%(group_by)s, name, operation) (
Expand All @@ -213,7 +214,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
/
sum by(%(group_by)s, name, operation) (
rate(thanos_cache_operations_total{operation!~"add|delete"}[%(range_interval)s])
)
) > 10
) * 100 > 5
||| % {
group_by: $._config.alert_aggregation_labels,
Expand Down
Loading