Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributor: Return specific error message when burst size limit exceeded #10835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Mar 9, 2025

What this PR does

Modify distributor to return specific error message when burst size limit exceeded, including the item count.

Which issue(s) this PR fixes or relates to

Fixes #10833.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@aknuds1 aknuds1 changed the title Distributor: Return specific error message when burst size limit exceeded WIP: Distributor: Return specific error message when burst size limit exceeded Mar 9, 2025
@aknuds1 aknuds1 added bug Something isn't working component/distributor labels Mar 9, 2025
@aknuds1 aknuds1 force-pushed the arve/fix-burst-error-message branch from ec38b50 to a994800 Compare March 9, 2025 09:42
@aknuds1 aknuds1 added enhancement New feature or request and removed bug Something isn't working labels Mar 9, 2025
@aknuds1 aknuds1 force-pushed the arve/fix-burst-error-message branch from a994800 to 1973d9b Compare March 9, 2025 09:50
@aknuds1 aknuds1 changed the title WIP: Distributor: Return specific error message when burst size limit exceeded Distributor: Return specific error message when burst size limit exceeded Mar 9, 2025
Comment on lines -7 to -9
* [FEATURE] Ingester/Distributor: Add support for exporting cost attribution metrics (`cortex_ingester_attributed_active_series`, `cortex_distributor_received_attributed_samples_total`, and `cortex_discarded_attributed_samples_total`) with labels specified by customers to a custom Prometheus registry. This feature enables more flexible billing data tracking. #10269 #10702
* [FEATURE] Ruler: Added `/ruler/tenants` endpoints to list the discovered tenants with rule groups. #10738
* [FEATURE] Distributor: Add experimental Influx handler. #10153
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGE entries are supposed to come before FEATURE entries.

@aknuds1 aknuds1 requested a review from bboreham March 9, 2025 09:53
@aknuds1 aknuds1 marked this pull request as ready for review March 9, 2025 10:00
@aknuds1 aknuds1 requested a review from a team as a code owner March 9, 2025 10:00
@aknuds1 aknuds1 force-pushed the arve/fix-burst-error-message branch from 1973d9b to 2e6d328 Compare March 9, 2025 10:04
@aknuds1 aknuds1 force-pushed the arve/fix-burst-error-message branch from 2e6d328 to 2c29161 Compare March 9, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: rate-limit message should let you know whether it was rate or burst that was exceeded.
1 participant