Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mimir-build-image to go1.22.4 #8307

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Upgrade mimir-build-image to go1.22.4 #8307

merged 5 commits into from
Jun 7, 2024

Conversation

fayzal-g
Copy link
Contributor

@fayzal-g fayzal-g commented Jun 7, 2024

What this PR does

Upgrades mimir-build-image to go1.22.4. Go 1.22.4 includes security fixes.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@fayzal-g fayzal-g requested a review from a team as a code owner June 7, 2024 12:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr8307-7034e42151. This can take up to 1 hour.

@fayzal-g fayzal-g force-pushed the upgrade-go-version branch from 9b5ffc0 to 54eef6a Compare June 7, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr8307-9918b003de. This can take up to 1 hour.

pstibrany
pstibrany approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany enabled auto-merge (squash) June 7, 2024 16:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8307-9918b003de already exists.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8307-9918b003de already exists.

@pstibrany pstibrany merged commit 3c5b850 into main Jun 7, 2024
30 checks passed
@pstibrany pstibrany deleted the upgrade-go-version branch June 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

@wilfriedroset wilfriedroset Awaiting requested review from wilfriedroset wilfriedroset is a code owner

@vaxvms vaxvms Awaiting requested review from vaxvms vaxvms is a code owner

@bubu11e bubu11e Awaiting requested review from bubu11e bubu11e is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fayzal-g @pstibrany