Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable colors on mimirtool's output when no terminal is detected #9423

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Disable colors on mimirtool's output when no terminal is detected #9423

merged 5 commits into from
Sep 26, 2024

Conversation

jadolg
Copy link
Contributor

@jadolg jadolg commented Sep 26, 2024 •
edited
Loading

What this PR does

  • Disables colored output on mimirtool when the output is not to a terminal.
  • Adds a flag (--force-color) to be able to enable colored output when the output is not to a terminal

Which issue(s) this PR fixes or relates to

Fixes #9119

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jadolg jadolg requested review from stevesg, grafanabot and a team as code owners September 26, 2024 09:07
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

56quarters
56quarters approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Just small changes to the CHANGELOG

@56quarters 56quarters enabled auto-merge (squash) September 26, 2024 21:47
@56quarters 56quarters merged commit ebb6230 into grafana:main Sep 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@56quarters 56quarters 56quarters approved these changes

@stevesg stevesg Awaiting requested review from stevesg stevesg is a code owner

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mimirtool not use color when pointed to non-tty output
3 participants
@jadolg @CLAassistant @56quarters