Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: fix autoscaling panels #9450

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Dashboards: fix autoscaling panels #9450

merged 3 commits into from
Sep 27, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

Autoscaling panels queries are wrong after #9412, due to a couple of main issues:

  1. One query is syntactically wrong
  2. Aggregations are wrong, we need to aggregate on different labels or aggregate after relabelling (I preferred to aggregate after relabelling to fix it)

Preview of fixed panels:
Screenshot 2024-09-27 at 15 37 34

Screenshot 2024-09-27 at 15 37 29

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci requested a review from a team as a code owner September 27, 2024 13:41
@pracucci pracucci merged commit c32f412 into main Sep 27, 2024
31 checks passed
@pracucci pracucci deleted the fix-autoscaling-panels branch September 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants