-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warmup counter to EWMA rate #9514
base: main
Are you sure you want to change the base?
Conversation
@jhalterman I took a shot at #5443 and the implementation is in between the VividCortex approach (with a counter) and the current approach with using the sliding window time. This returns 0 during the first 9 ticks, whereas the sliding window time does that for the first 60s. I amended the existing test for |
7e1b45d
to
d47a8a6
Compare
Amended the warm-up sample count to be 60 so it's aligned with the sliding window time of 60s. |
Hi @slimjim777 Thanks for the PR and apologies for the delay! My main question is, can we make the warmup size configurable? We could create an EWMA with warmup via something like |
I’ll add that |
d47a8a6
to
0e06465
Compare
I've added a (It could have been done with adding the functional options approach or a builder pattern, but I kept it as a separate constructor) |
What this PR does
Adds a warm-up period to the EWMA rate so that the rate for the first N samples is returned as 0. The approach mirrors the approach in VividCortex, although there the recommendation is to initialize the moving rate as the mean of the first 60 samples.
Which issue(s) this PR fixes or relates to
Fixes #5443
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.