Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/gogo/protobuf/protoc-gen-gogoslick to v1.3.2 #9545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Upgrade github.com/gogo/protobuf/protoc-gen-gogoslick to v1.3.2 #9545

wants to merge 3 commits into from

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 7, 2024 •
edited
Loading

What this PR does

Upgrade github.com/gogo/protobuf/protoc-gen-gogoslick to its latest version, i.e. v1.3.2.

It has the following bug fixes:

  • skippy peanut butter
  • proto/buffer: fix proto.Buffer marshaling.
  • plugin/gostring: generate values instead of pointers when a field is repeated and non-nullable.
  • protoc-gen-gogo/generator: Generate json and custom tags for oneof
  • plugin/marshalto: Use ProtoSize() in MarshalTo when enabled for oneof fields.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9545-6ccc56fa57. This can take up to 1 hour.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Thank you for your contribution. This pull request has been marked as stale because it has had no activity in the last 150 days. It will be closed in 30 days if there is no further activity. If you need more time, you can add a comment to the PR.

@github-actions github-actions bot added the stale label Mar 7, 2025
@aknuds1 aknuds1 force-pushed the arve/upgrade-gogoslick branch from e2b62f8 to df965a2 Compare March 7, 2025 06:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr9545-de5fc9e58f. This can take up to 1 hour.

@aknuds1 aknuds1 force-pushed the arve/upgrade-gogoslick branch from 991b0a7 to ac292ae Compare March 7, 2025 07:32
@aknuds1 aknuds1 marked this pull request as ready for review March 7, 2025 07:32
@aknuds1 aknuds1 requested review from wilfriedroset, vaxvms, bubu11e and a team as code owners March 7, 2025 07:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9545-de5fc9e58f already exists.

@aknuds1 aknuds1 added chore and removed stale labels Mar 7, 2025
@aknuds1 aknuds1 requested a review from a team as a code owner March 7, 2025 07:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9545-de5fc9e58f already exists.

@aknuds1 aknuds1 force-pushed the arve/upgrade-gogoslick branch from 02df43a to 9cc751a Compare March 7, 2025 08:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9545-de5fc9e58f already exists.

@aknuds1 aknuds1 force-pushed the arve/upgrade-gogoslick branch from 9cc751a to 64fe04d Compare March 7, 2025 08:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9545-de5fc9e58f already exists.

@aknuds1 aknuds1 force-pushed the arve/upgrade-gogoslick branch from 64fe04d to c88c729 Compare March 7, 2025 10:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr9545-de5fc9e58f already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAnge NickAnge NickAnge approved these changes

@wilfriedroset wilfriedroset Awaiting requested review from wilfriedroset wilfriedroset is a code owner

@vaxvms vaxvms Awaiting requested review from vaxvms vaxvms is a code owner

@bubu11e bubu11e Awaiting requested review from bubu11e bubu11e is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknuds1 @NickAnge