[r314] kafka replay speed: dynamic ingestion concurrency #9797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* kafka replay speed: dynamic ingestion concurrency #### Background we've found that ingestion concurrency maybe adds overhead. #### What this PR does This PR makes changes so that we choose concurrency dynamically based on the amount of data (# of timeseries) we will ingest. #### How it works We try to flush each shard a lot of times in order to gain the benefit of concurrency. If the estimation is that we won't flush it that often, then we choose not to run concurrently for the particular tenant|source combination. #### Estimations/Assumptions Currently, we target 80 flushes per shard as this number seems to work ok. The estimation of bytes per timeseries is almost mostly there for a lot of our dev and production cells. Signed-off-by: Dimitar Dimitrov <[email protected]> * address review comments --------- Signed-off-by: Dimitar Dimitrov <[email protected]> Signed-off-by: gotjosh <[email protected]> Co-authored-by: gotjosh <[email protected]> (cherry picked from commit 77f5bf1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 77f5bf1 from #9739