-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/support escalations 11817 #9907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there, let me know what you think about my comments.
@@ -13,103 +13,103 @@ weight: 150 | |||
To send OTel data to Grafana Cloud, refer to [Send data using OpenTelemetry Protocol (OTLP)](https://grafana.com/docs/grafana-cloud/send-data/otlp/send-data-otlp/). | |||
{{% /admonition %}} | |||
|
|||
When using the [OpenTelemetry Collector](https://opentelemetry.io/docs/collector/), you can write metrics into Mimir via two options: `prometheusremotewrite` and `otlphttp`. | |||
When using the [OpenTelemetry Collector](https://opentelemetry.io/docs/collector/), you can write metrics into Mimir using two options: `otlphttp` (preferred) and `prometheusremotewrite`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say here we recommend the usage of otlphttp.
The reason why we recommend this is because the exporter is maintained by the community and always up to date with the spec. It's the official way of sending OTLP traffic and we want to recommend the more native path.
Prometheus Remote Write is an exporter in the https://github.com/open-telemetry/opentelemetry-collector-contrib repository donated by the community that is in beta
stage https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/prometheusremotewriteexporter
We strongly recommend otlphttp. We can leave the example at the bottom of prometheusremotewrite as an experimental section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rework the doc a bit to more strongly favor otlphttp over prometheus remote write.
cc @aknuds1 in case you'd like to review this one 🙏 |
@jesusvazquez I've updated the doc to strongly recommend OTLP and to mark Prometheus remote write as experimental. LMK what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @tacole02 !
Thank you so much for you input, @jesusvazquez ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
Co-authored-by: Arve Knudsen <[email protected]>
@jesusvazquez , @aknuds1 , any thoughts on whether to denote Prometheus remote write support as experimental? If it's not technically experimental, we can always remove that admonition while continuing to strongly recommend otlphttp. Thanks! |
@tacole02 please see my response above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tacole02 sorry for misleading you. What is "experimental" or beta according to the docs, is the prometheus remote write exporter for the otel collector. For mimir and prometheus, prometheus remote write is completely stable and recommended |
What this PR does
This PR updates https://grafana.com/docs/mimir/next/configure/configure-otel-collector/ to explicitly recommend using the OTLP exporter, when possible, for sending OTLP data to Mimir.
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/support-escalations/issues/11817
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.