Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus Middleware to Router to add HTTP Metrics #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SeamusGrafana
Copy link
Contributor

Somewhere between v0.11.0 and v0.12.0 the HTTP Metrics in Prometheus (such as http_request_duration_seconds_bucket and http_requests_total were missing and no longer show.

It looks like the Router no longer had the Prometheus Middleware Included so it was not generating these.

This re-adds that configuration to generate the Metrics again.

@federicotdn
Copy link
Contributor

Hi, I've fixed this by changing how Quickpizza installs chi middleware, before it was using a strange combination of .Use() and .With() that broke stuff. I'll push this to production soon but it's already in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants