Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneShareLinksButton: expose share links button to scene apps #1022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SceneShareLinksButton: expose share links button to scene apps #1022

wants to merge 1 commit into from
+261 −0

Conversation

gtk-grafana
Copy link
Contributor

Exposes SceneShareLinksButton scene for scene apps.
SceneShareLinksButton allows consumers to define:

  • optional onCopyLink callback (for tracking) on link copy
  • optional getSceneTimeRange function to specify which SceneTimeRangeLike should be used for the link generation.
image
image

@gtk-grafana gtk-grafana self-assigned this Jan 7, 2025
@gtk-grafana gtk-grafana added usecase/app-plugins Needed for scene app plugins release Create a release when this pr is merged minor Increment the minor version when merged labels Jan 7, 2025
@gtk-grafana gtk-grafana marked this pull request as ready for review January 7, 2025 16:53
@gtk-grafana gtk-grafana mentioned this pull request Jan 7, 2025
Merged
@gtk-grafana gtk-grafana requested review from dprokop and torkelo January 9, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@mdvictor mdvictor Awaiting requested review from mdvictor

@dprokop dprokop Awaiting requested review from dprokop

@torkelo torkelo Awaiting requested review from torkelo

At least 1 approving review is required to merge this pull request.

Assignees

@gtk-grafana gtk-grafana

Labels
minor Increment the minor version when merged release Create a release when this pr is merged usecase/app-plugins Needed for scene app plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gtk-grafana