AdHocVariable: Edit injected filters #1062
Conversation
mdvictor
added
minor
| filtersVar._updateFilter(filtersVar.state.filters[0], { key: 'newKey', keyLabel: 'newKey' }); | ||
| }); | ||
|
|
||
| // injected filters stored in the following format: normal|adhoc|values\original|values\filterOrigin |
There was a problem hiding this comment.
I think the format is fine, question is if you sync them always? I think we should probably sync them only when they have changed, otherwise one will navigate to a dashboard in the same scope.
There was a problem hiding this comment.
I think you are right. I kept thinking about this and initially thought that both normal filters and baseFilters with an origin should be treated the same, thus having these baseFilters in the URL, same as your average filter, but I agree that there is no point in having both unmodified scope injected filter and the scope itself in there
| private getInjectedKey(): string { | ||
| return `var-injected-${this._variable.state.name}`; | ||
| } |
There was a problem hiding this comment.
Why do we need to do this? I think we could sync the injected alongside the regular filters (keys that are injected can't be really overwritten by the user) and figure out which filters were scope-injected based on keys matching and origin. WDYT?
There was a problem hiding this comment.
Indeed, no need for another key other than for verbosity, we can identify injected filters based on origin. Removing the extra key
Allows adhocs to show and edit base filters if they have an origin.
Holds base filters into url sync to allow for passing them over from one dashboard to another, alongside the source and original value of a injected filter.
📦 Published PR as canary version:
6.2.0--canary.1062.13673471910.0✨ Test out this PR locally via: