Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails 7: grails-spring-security-cas #107

Merged
merged 9 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'adopt'
bkoehm marked this conversation as resolved.
Show resolved Hide resolved
java-version: 11
java-version: 17
- name: Run Tests
if: github.event_name == 'pull_request'
id: tests
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'adopt'
bkoehm marked this conversation as resolved.
Show resolved Hide resolved
java-version: '11'
java-version: '17'
- name: Set the current release version
id: release_version
run: echo "value=${GITHUB_REF:11}" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
java-version: '17'
- name: Checkout repository
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
java-version: '17'
- name: Checkout repository
uses: actions/checkout@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
buildscript {
repositories {
maven { url "https://repo.grails.org/grails/core" }
mavenCentral()
maven { url "https://repo.grails.org/grails/core" }
gradlePluginPortal()
}
dependencies {
Expand All @@ -25,7 +25,7 @@ subprojects { project->
}

dependencies {
documentation "com.github.javaparser:javaparser-core:3.25.8"
documentation "com.github.javaparser:javaparser-core:3.26.2"
}

tasks.withType(Groovydoc).configureEach {
Expand Down
10 changes: 5 additions & 5 deletions docs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ buildscript {
maven { url 'https://repo.grails.org/grails/core' }
}
dependencies {
classpath 'org.asciidoctor:asciidoctor-gradle-jvm:3.3.2'
classpath "org.asciidoctor:asciidoctor-gradle-jvm-epub:3.3.2"
classpath "org.asciidoctor:asciidoctor-gradle-jvm-pdf:3.3.2"
classpath "org.asciidoctor:asciidoctor-gradle-jvm-gems:3.3.2"
classpath 'org.asciidoctor:asciidoctor-gradle-jvm:4.0.3'
classpath "org.asciidoctor:asciidoctor-gradle-jvm-epub:4.0.3"
classpath "org.asciidoctor:asciidoctor-gradle-jvm-pdf:4.0.3"
classpath "org.asciidoctor:asciidoctor-gradle-jvm-gems:4.0.3"
}
}

Expand Down Expand Up @@ -45,7 +45,7 @@ repositories {
}

dependencies {
asciidoctorGems 'rubygems:rouge:3.15.0'
asciidoctorGems 'rubygems:rouge:4.4.0'
}


Expand Down
11 changes: 6 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
projectVersion=6.0.0-SNAPSHOT
grailsVersion=6.1.0
grailsVersion=7.0.0-SNAPSHOT
threeZeroXProjectVersion=3.0.1
casClientCoreVersion=3.6.4
springSecurityCoreVersion=5.3.0
springSecurityVersion=5.8.9
javaxServletApiVersion=4.0.1
assetPipelineVersion=4.4.0
springSecurityCoreVersion=7.0.0-SNAPSHOT
springSecurityVersion=6.3.3
jakartaServletApiVersion=6.0.0
assetPipelineVersion=5.0.1
groovyVersion=4.0.22
projectDesc=The CAS plugin adds CAS single sign-on support to a Grails application that uses Spring Security.
projectUrl=https://github.com/grails/grails-spring-security-cas
githubSlug=grails/grails-spring-security-cas
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.1-bin.zip
bkoehm marked this conversation as resolved.
Show resolved Hide resolved
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
18 changes: 14 additions & 4 deletions gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
# Darwin, MinGW, and NonStop.
#
# (3) This script is generated from the Groovy template
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# within the Gradle project.
#
# You can find Gradle at https://github.com/gradle/gradle/.
Expand All @@ -80,10 +80,10 @@ do
esac
done

APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="Gradle"
# This is normally unused
# shellcheck disable=SC2034
APP_BASE_NAME=${0##*/}
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
Expand Down Expand Up @@ -143,12 +143,16 @@ fi
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
MAX_FD=$( ulimit -H -n ) ||
warn "Could not query maximum file descriptor limit"
esac
case $MAX_FD in #(
'' | soft) :;; #(
*)
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
ulimit -n "$MAX_FD" ||
warn "Could not set maximum file descriptor limit to $MAX_FD"
esac
Expand Down Expand Up @@ -205,6 +209,12 @@ set -- \
org.gradle.wrapper.GradleWrapperMain \
"$@"

# Stop when "xargs" is not available.
if ! command -v xargs >/dev/null 2>&1
then
die "xargs is not available"
fi

# Use "xargs" to parse quoted args.
#
# With -n1 it outputs one arg per line, with the quotes and backslashes removed.
Expand Down
15 changes: 9 additions & 6 deletions gradlew.bat
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
@rem limitations under the License.
@rem

@if "%DEBUG%" == "" @echo off
@if "%DEBUG%"=="" @echo off
@rem ##########################################################################
@rem
@rem Gradle startup script for Windows
Expand All @@ -25,7 +25,8 @@
if "%OS%"=="Windows_NT" setlocal

set DIRNAME=%~dp0
if "%DIRNAME%" == "" set DIRNAME=.
if "%DIRNAME%"=="" set DIRNAME=.
@rem This is normally unused
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%

Expand All @@ -40,7 +41,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome

set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto execute
if %ERRORLEVEL% equ 0 goto execute

echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
Expand Down Expand Up @@ -75,13 +76,15 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar

:end
@rem End local scope for the variables with windows NT shell
if "%ERRORLEVEL%"=="0" goto mainEnd
if %ERRORLEVEL% equ 0 goto mainEnd

:fail
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
rem the _cmd.exe /c_ return code!
if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
exit /b 1
set EXIT_CODE=%ERRORLEVEL%
if %EXIT_CODE% equ 0 set EXIT_CODE=1
if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%
exit /b %EXIT_CODE%

:mainEnd
if "%OS%"=="Windows_NT" endlocal
Expand Down
27 changes: 23 additions & 4 deletions plugin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,25 @@ buildscript {
version = projectVersion
group = 'org.grails.plugins'

configurations {
all {
exclude group: 'javax.servlet'
exclude group: 'javax.xml.bind'
}
}

apply plugin: 'eclipse'
apply plugin: 'idea'
apply plugin: 'java-library'
apply plugin: 'maven-publish'
apply plugin: 'signing'
apply plugin: 'org.grails.grails-plugin'

sourceCompatibility = 1.11
targetCompatibility = 1.11
java {
toolchain {
languageVersion = JavaLanguageVersion.of(17)
}
}

ext."signing.keyId" = project.hasProperty("signing.keyId") ? project.getProperty('signing.keyId') : System.getenv('SIGNING_KEY')
ext."signing.secretKeyRingFile" = project.hasProperty("signing.secretKeyRingFile") ? project.getProperty('signing.secretKeyRingFile') : "${System.properties['user.home']}${File.separator}.gnupg${File.separator}secring.gpg"
Expand Down Expand Up @@ -62,8 +72,17 @@ configurations {
documentation.extendsFrom compileClasspath
}

configurations.configureEach {
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
if ((details.requested.group == 'org.codehaus.groovy' || details.requested.group == 'org.apache.groovy') && details.requested.name != 'groovy-bom') {
details.useTarget(group: 'org.apache.groovy', name: details.requested.name, version: groovyVersion)
details.because "The dependency coordinates are changed in Apache Groovy 4, plus ensure version"
}
}
}

dependencies {
compileOnly "javax.servlet:javax.servlet-api:$javaxServletApiVersion"
compileOnly "jakarta.servlet:jakarta.servlet-api:$jakartaServletApiVersion"
compileOnly "org.springframework.boot:spring-boot-starter-logging"
compileOnly "org.grails:grails-web-boot"

Expand All @@ -78,7 +97,7 @@ dependencies {
'spring-security-web', 'spring-web'].each { exclude module: it }
}

documentation "com.github.javaparser:javaparser-core:3.25.8"
documentation "com.github.javaparser:javaparser-core:3.26.2"
}

tasks.withType(Groovydoc).configureEach {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import grails.plugins.Plugin
@CompileStatic
class SpringSecurityCasGrailsPlugin extends Plugin {

String grailsVersion = '3.0.0 > *'
String grailsVersion = '7.0.0 > *'
String author = 'Burt Beckwith'
String authorEmail = '[email protected]'
String title = 'Jasig CAS support for the Spring Security plugin.'
Expand Down
18 changes: 13 additions & 5 deletions testapps/spring-security-cas-test1/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}
dependencies {
classpath "org.grails:grails-gradle-plugin:$grailsVersion"
classpath "org.grails.plugins:hibernate5:${gormVersion-".RELEASE"}"
classpath "org.grails.plugins:hibernate5:$gormVersion"
classpath "com.bertramlabs.plugins:asset-pipeline-gradle:$assetPipelineVersion"
}
}
Expand All @@ -32,6 +32,15 @@ configurations {
}
}

configurations.configureEach {
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
bkoehm marked this conversation as resolved.
Show resolved Hide resolved
if ((details.requested.group == 'org.codehaus.groovy' || details.requested.group == 'org.apache.groovy') && details.requested.name != 'groovy-bom') {
details.useTarget(group: 'org.apache.groovy', name: details.requested.name, version: groovyVersion)
details.because "The dependency coordinates are changed in Apache Groovy 4, plus ensure version"
}
}
}

dependencies {
developmentOnly "org.springframework.boot:spring-boot-devtools"
compile "org.springframework.boot:spring-boot-starter-logging"
Expand All @@ -52,19 +61,18 @@ dependencies {
compile "org.grails.plugins:scaffolding"
compile "org.grails.plugins:events"
compile "org.grails.plugins:hibernate5"
compile "org.hibernate:hibernate-core:5.6.15.Final"
compile "org.hibernate:hibernate-core-jakarta:5.6.15.Final"
compile "org.grails.plugins:gsp"
console "org.grails:grails-console"
profile "org.grails.profiles:web"
runtime "org.glassfish.web:el-impl:2.2"
runtime "com.h2database:h2"
runtime "org.apache.tomcat:tomcat-jdbc"
runtime "com.bertramlabs.plugins:asset-pipeline-grails:$assetPipelineVersion"
testCompile "org.grails:grails-gorm-testing-support"
testCompile "org.grails.plugins:geb"
testCompile "org.grails:grails-web-testing-support"
testRuntime "org.seleniumhq.selenium:selenium-htmlunit-driver:2.52.0"
testRuntime "net.sourceforge.htmlunit:htmlunit:2.70.0"
testRuntime "org.seleniumhq.selenium:selenium-htmlunit-driver:4.13.0"
testRuntime "org.htmlunit:htmlunit:4.4.0"

compile project(':spring-security-cas')
}
Expand Down
5 changes: 3 additions & 2 deletions testapps/spring-security-cas-test1/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
grailsVersion=5.3.1
gormVersion=7.2.0
grailsVersion=7.0.0-SNAPSHOT
gormVersion=9.0.0-SNAPSHOT
groovyVersion=4.0.22
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Fri Nov 27 23:09:32 CET 2015
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.1-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-3.5.1-bin.zip
Loading
Loading