Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and return alternate_place_names #608

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cajturner
Copy link

Return place name value and formatted date string

Added based on discussion here: gramps-project/gramps-web#566

@@ -513,13 +513,15 @@ def test_get_places_handle_parameter_profile(self):
rv["profile"],
{
"alternate_names": [],
"alternate_place_names": [],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure how the test data is created. How can I create a Place with alt names?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidMStraub can you point me in the right direction for setting up new test data?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah from the gramps example db. I will update the tests

@DavidMStraub
Copy link
Member

Can you please ping me when it's ready to merge? I'll convert to draft in the meantime.

@DavidMStraub DavidMStraub marked this pull request as draft February 14, 2025 08:28
@cajturner
Copy link
Author

Can you please ping me when it's ready to merge? I'll convert to draft in the meantime.

Yes, will do. I have a new born baby that has just arrived so could be a few weeks before I can look

@DavidMStraub
Copy link
Member

Congrats on that family tree extension! 😆 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants