Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken typescript compilation #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianmarmour
Copy link

Typescript breaks on compilation because of an invalid use of reference types, see this documentation as to why the previous usage of reference types to refer to a relative path is invalid.

node_modules/graphql-compose-elasticsearch/lib/ElasticApiParser.d.ts:1:23 - error TS2688: Cannot find type definition file for 'src/types'.

1 /// <reference types="src/types" />
                        ~~~~~~~~~

Was able to remove this line locally and re-build and validated that this works fine and solves the build failures.

Typescript breaks on compilation because of an invalid use of reference types, see (this documentation)[https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-types-] as to why reference types is invalid

```
node_modules/graphql-compose-elasticsearch/lib/ElasticApiParser.d.ts:1:23 - error TS2688: Cannot find type definition file for 'src/types'.

1 /// <reference types="src/types" />
                        ~~~~~~~~~
```

Was able to remove this line locally and re-build and validated that this works fine and solves the build failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant