Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coercion of typedef primitives and their pointers #489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix coercion of typedef primitives and their pointers #489

wants to merge 1 commit into from

Conversation

atombender
Copy link
Contributor

For example, with type MyInt int, values of type MyInt and *MyInt should be treated as ints. Without this fix, they return the pointer value, e.g. 0xc00000f500. Fixes #488.

@atombender atombender force-pushed the issue-488 branch 2 times, most recently from f144ea4 to 2bf3a1d Compare June 14, 2019 17:16
@coveralls
Copy link

coveralls commented Jun 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 92.318% when pulling 0d8ef75 on atombender:issue-488 into 199d20b on graphql-go:master.

@atombender
Fix coercion of typedef primitives and their pointers. For example,
0d8ef75 
with "type MyInt int", values of type MyInt and *MyInt should be treated
as ints. Fixes graphql-go#488.
@atombender
Copy link
Contributor Author

@sogko @chris-ramon @Fontinalis Review, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aliased pointer types become pointer addresses
2 participants
@atombender @coveralls