Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: updates go version #718

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

chris-ramon
Copy link
Member

Details

  • .circleci: Updates go version.

Test Plan

  • ✔️ Tested that circleci works as expected via GitHub builds.

@chris-ramon chris-ramon self-assigned this Apr 1, 2025
Copy link

mentatbot bot commented Apr 1, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

Copy link

mentatbot bot commented Apr 1, 2025

Hi @chris-ramon, thanks for updating the CircleCI configuration to use more modern Go versions!

I noticed a couple of things that might need attention:

  1. There's a mismatch between the Go version in go.mod (which specifies go 1.13) and the versions being tested in CI (1.22.0, 1.23.0, 1.24.0). Depending on your intent, you might want to update the go.mod file as well.

  2. The coveralls job still uses circleci/golang:latest image, while the other jobs use cimg/go:. For consistency, would it make sense to update the coveralls job to use the same image prefix?

Overall, these changes look good and will help keep the CI infrastructure up to date. Let me know if you'd like me to make any additional suggestions!

@coveralls
Copy link

coveralls commented Apr 1, 2025

Coverage Status

coverage: 92.048%. remained the same
when pulling 5a1a6bb on updating-circleci
into 58689e0 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants