Allow to use v2.8, but not context and fromContext directives #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkisiela
force-pushed
the
kamil-2.7-partial
branch
from
118319b to
84b1d29
Compare
kamilkisiela
force-pushed
the
kamil-2.8-partial
branch
3 times, most recently
from
6f7f766 to
358af91
Compare
n1ru4l
reviewed
Mar 27, 2025
n1ru4l
reviewed
Mar 27, 2025
| patterns.push(`@${name}`); | ||
| }); | ||
|
|
||
| return new RegExp(patterns.join('|')).test(sdl); |
There was a problem hiding this comment.
Regex creation could be cached as well?
kamilkisiela
force-pushed
the
kamil-2.8-partial
branch
from
358af91 to
345d775
Compare
Co-authored-by: Laurin Quast <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #85, but does not close it