Improve tests and utils around public schema #118
Merged
+1,051
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the link utils Jeff created (
extractLinkImplementations).I changed the logic of
transformSupergraphToPublicSchemaandcontainsSupergraphSpecto reuse what is defined insrc/specifications. The supergraph to public schema transformation supports now aliasing.I added quite a lot of tests to check if the
publicSdlwe're producing is correct.The
assertCompositionSuccessfunction that is used in tests, builds a GraphQLSchema instance from thepublicSdl(in case of Apollo it uses their own api to achieve the same thing) and validates it. This way we can assume thepublicSdlis valid and executable.