Adds @inaccessible directive #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glen-84
suggested changes
Nov 10, 2024
| type Product @key(fields: "id") @key(fields: "sku") { | ||
| id: ID! | ||
| sku: String! @inaccessible | ||
| internalNote: String |
There was a problem hiding this comment.
The prefix internal makes it sound as if this field might be a candidate for the @internal or @inaccessible directive, but that is not applied here. Perhaps this field should just be named note or something else like title or description? (and below)
| } | ||
| ``` | ||
|
|
||
| The above example declares the key field `sku` to be inaccessible through from |
There was a problem hiding this comment.
Suggested change
| The above example declares the key field `sku` to be inaccessible through from | |
| The above example declares the key field `sku` to be inaccessible from |
|
|
||
| The above example declares the key field `sku` to be inaccessible through from | ||
| the composite schema. However, type system members marked as inaccessible can | ||
| still be used within the composite execution schema to fulfill requirements or |
There was a problem hiding this comment.
Suggested change
| still be used within the composite execution schema to fulfill requirements or | |
| still be used within the composite execution schema to fulfil requirements or |
| lookups. | ||
|
|
||
| In contrast to the `@internal` directive the `@inaccessible` directive hides a | ||
| type member from composite schema even if other source schemas on the same type |
There was a problem hiding this comment.
Suggested change
| type member from composite schema even if other source schemas on the same type | |
| type member from the composite schema even if other source schemas on the same type |
| } | ||
|
|
||
| # Composite Schema | ||
|
|
| } | ||
| ``` | ||
|
|
||
| The above example removes the field `internalProductById` and the type `Product` |
There was a problem hiding this comment.
Suggested change
| The above example removes the field `internalProductById` and the type `Product` | |
| The example below removes the field `internalProductById` and the type `Product` |
|
|
||
| The above example removes the field `internalProductById` and the type `Product` | ||
| from the the composite schema. However, type system members marked as | ||
| inaccessible can still be used within the composite execution schema to fulfill |
There was a problem hiding this comment.
Suggested change
| inaccessible can still be used within the composite execution schema to fulfill | |
| inaccessible can still be used within the composite execution schema to fulfil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.