GraphiQL v4 #3685

dimaMachina · 2024-08-07T12:39:36Z

No description provided.

changeset-bot · 2024-08-07T12:39:40Z

🦋 Changeset detected

Latest commit: 068e23c

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-08-07T12:50:43Z

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * Update .changeset/thirty-spoons-call.md * fix cypress * this fix locally --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>

codecov · 2024-08-07T13:51:42Z

Codecov Report

Attention: Patch coverage is 85.13514% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.30%. Comparing base (a929862) to head (068e23c).

Files	Patch %	Lines
packages/graphiql-react/src/editor/hooks.ts	20.00%	4 Missing ⚠️
packages/graphiql/test/schema.js	33.33%	4 Missing ⚠️
packages/graphiql/src/components/GraphiQL.tsx	94.33%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3685      +/-   ##
==========================================
- Coverage   65.32%   65.30%   -0.03%     
==========================================
  Files         122      121       -1     
  Lines        7003     7006       +3     
  Branches     2260     2263       +3     
==========================================
  Hits         4575     4575              
- Misses       2411     2414       +3     
  Partials       17       17

Files	Coverage Δ
packages/graphiql-react/src/editor/common.ts	`100.00% <100.00%> (ø)`
...hiql-react/src/editor/components/image-preview.tsx	`2.70% <ø> (+0.13%)`	⬆️
packages/graphiql-react/src/editor/query-editor.ts	`64.28% <100.00%> (+0.18%)`	⬆️
packages/graphiql-react/src/markdown.ts	`100.00% <ø> (ø)`
packages/graphiql-react/src/toolbar/menu.tsx	`66.66% <100.00%> (ø)`
packages/graphiql-react/src/ui/dialog.tsx	`100.00% <100.00%> (ø)`
packages/graphiql-react/src/ui/dropdown.tsx	`40.00% <100.00%> (ø)`
packages/graphiql-react/src/ui/tabs.tsx	`100.00% <100.00%> (ø)`
packages/graphiql-react/src/ui/tooltip.tsx	`100.00% <100.00%> (ø)`
packages/graphiql/src/components/GraphiQL.tsx	`78.54% <94.33%> (-0.04%)`	⬇️
... and 2 more

* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>

* new looks of tabs * add graphiql react too * all fixes * more polishing * more * more * more * more * more * prettier * polish changeset * disable shrinking while changing the operation name * Update packages/graphiql-react/src/ui/tabs.css Co-authored-by: Ted Thibodeau Jr <[email protected]> * yarn i * apply new design changes * prettier * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * Update .changeset/thirty-spoons-call.md * Update packages/graphiql/vite.config.mts * merge * add changeset * yarn.lock * yarn.lock --------- Co-authored-by: Ted Thibodeau Jr <[email protected]>

… remove development code from cdn bundle (#3683) * vite more more more * fix demo * fix cspell * fix dev * update cypress to v13 * upd cache key * remove webpack deps * fix `yarn jest --coverage` * upd graphql * aa * yarn.lock * fix tests

…ized branches to deploy

* remove `disableTabs` option * format

…over `window.navigator` (#3692)

* test umd build only on ci, locally test cdn.ts * Update custom-words.txt

* aa * fix netlify * fix * fix fails on ci

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* improve explorer styles * aa

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* add vite replace html plugin for graphiql plugin explorer * fix build

* aa * removes unneeded `undefined` * try * fix * fix vitest

acao · 2024-08-24T23:20:44Z

@dimaMachina what is the rationale behind removing the disableTabs option?

acao · 2024-08-24T23:21:47Z

packages/graphiql-react/src/editor/hooks.ts

+   * @param query The current value of the query editor.
+   * @returns {string} The formatted query
+   */
+  onPrettifyQuery?: (query: string) => string;


@dimaMachina along the lines of our previous discussion, i think we should discontinue exposing handlers and state via props, and expose them via hooks instead, then people can provide formatters as plugins. in this case it's simply a callback and no state, so it doesn't impact the controlled vs uncontrolled scenario, but for something like this that is more likely to be used by plugins, we should expose that instead, and provider a prettier plugin

we already expose the use editor hooks and users can use the refs, so a compositional @graphiql/react experience already exists (as of course GraphiQL has been!), so we should just provide a simple example in examples of a custom editor?

acao · 2024-08-24T23:32:16Z

packages/graphiql-react/src/editor/hooks.ts

+   * @param query The current value of the query editor.
+   * @returns {string} The formatted query
+   */
+  onPrettifyQuery?: (query: string) => string;


Suggested change

onPrettifyQuery?: (query: string) => string;

onPrettifyQuery?: async (query: string) => string;

and the required changes as such, as prettier.format returns a promise, for example

changeset pre enter alpha

fec285b

dimaMachina and others added 3 commits August 7, 2024 16:01

Merge branch 'main' into graphiql-v4

955573a

dimaMachina had a problem deploying to deploy August 7, 2024 14:19 — with GitHub Actions Failure

dimaMachina had a problem deploying to deploy August 7, 2024 14:40 — with GitHub Actions Failure

dimaMachina had a problem deploying to deploy August 7, 2024 14:43 — with GitHub Actions Failure

remove data-testid="graphiql-container" (#3688)

0fdd9b9

dimaMachina had a problem deploying to deploy August 7, 2024 14:56 — with GitHub Actions Failure

commit pre.json until graphiql-v4 will be added to list of author…

c5b3aa2

…ized branches to deploy

dimaMachina had a problem deploying to deploy August 7, 2024 15:00 — with GitHub Actions Failure

dimaMachina added 4 commits August 7, 2024 17:02

remove graphiql-v4 from release.yml

61fc27a

[v4] remove disableTabs option (#3687)

09e7004

* remove `disableTabs` option * format

commit pre.json

11bacb8

add graphiql-v4 in release.yml

445bf02

dimaMachina temporarily deployed to deploy August 7, 2024 17:12 — with GitHub Actions Inactive

Merge branch 'main' into graphiql-v4

d34246e

dimaMachina temporarily deployed to deploy August 7, 2024 20:33 — with GitHub Actions Inactive

[v4] prefer location over window.location and prefer navigator …

82bc961

…over `window.navigator` (#3692)

dimaMachina temporarily deployed to deploy August 7, 2024 22:58 — with GitHub Actions Inactive

[v4] remove build.sh and checkgit.sh (#3694)

93453fc

dimaMachina temporarily deployed to deploy August 7, 2024 23:06 — with GitHub Actions Inactive

[v4] test umd build only on ci, locally test cdn.ts (#3693)

2005871

* test umd build only on ci, locally test cdn.ts * Update custom-words.txt

dimaMachina temporarily deployed to deploy August 7, 2024 23:07 — with GitHub Actions Inactive

[v4] convert graphiql e2e server to ESM (#3697)

bf3ea52

* aa * fix netlify * fix * fix fails on ci

dimaMachina temporarily deployed to deploy August 15, 2024 17:06 — with GitHub Actions Inactive

Merge branch 'main' into graphiql-v4

e10e96c

dimaMachina temporarily deployed to deploy August 15, 2024 18:43 — with GitHub Actions Inactive

Version Packages (alpha) (#3732)

3a2580e

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

dimaMachina temporarily deployed to deploy August 15, 2024 18:52 — with GitHub Actions Inactive

[v4] improve explorer styles (#3738)

eaa415c

* improve explorer styles * aa

dimaMachina temporarily deployed to deploy August 19, 2024 16:20 — with GitHub Actions Inactive

Version Packages (alpha) (#3739)

dfb302a

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

dimaMachina temporarily deployed to deploy August 19, 2024 16:24 — with GitHub Actions Inactive

fix types incorrect types entry (#3740)

3c12ce0

dimaMachina temporarily deployed to deploy August 20, 2024 12:50 — with GitHub Actions Inactive

Version Packages (alpha) (#3741)

e432fb5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

dimaMachina temporarily deployed to deploy August 20, 2024 13:00 — with GitHub Actions Inactive

add vite replace html plugin for graphiql plugin explorer (#3742)

ffaf5c9

* add vite replace html plugin for graphiql plugin explorer * fix build

dimaMachina temporarily deployed to deploy August 20, 2024 13:40 — with GitHub Actions Inactive

Merge branch 'main' into graphiql-v4

f042025

dimaMachina temporarily deployed to deploy August 22, 2024 17:40 — with GitHub Actions Inactive

dimaMachina added 2 commits August 23, 2024 18:41

temp

befbd04

Merge branch 'main' into graphiql-v4

fdcecaf

dimaMachina had a problem deploying to deploy August 23, 2024 18:37 — with GitHub Actions Failure

migrate @graphiql/toolkit to tsup (#3746)

78cb500

* aa * removes unneeded `undefined` * try * fix * fix vitest

dimaMachina had a problem deploying to deploy August 23, 2024 18:49 — with GitHub Actions Failure

rollback of temp commit

3c48be0

dimaMachina temporarily deployed to deploy August 23, 2024 18:54 — with GitHub Actions Inactive

Merge branch 'main' into graphiql-v4

068e23c

dimaMachina temporarily deployed to deploy August 24, 2024 14:22 — with GitHub Actions Inactive

acao reviewed Aug 24, 2024

View reviewed changes

acao added this to the [email protected] milestone Aug 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphiQL v4 #3685

GraphiQL v4 #3685

dimaMachina commented Aug 7, 2024

changeset-bot bot commented Aug 7, 2024 •

edited

Loading

github-actions bot commented Aug 7, 2024 •

edited

Loading

codecov bot commented Aug 7, 2024 •

edited

Loading

acao commented Aug 24, 2024

acao Aug 24, 2024

acao Aug 24, 2024 •

edited

Loading

acao Aug 24, 2024

acao Aug 24, 2024

	onPrettifyQuery?: (query: string) => string;
	onPrettifyQuery?: async (query: string) => string;

GraphiQL v4 #3685

Are you sure you want to change the base?

GraphiQL v4 #3685

Conversation

dimaMachina commented Aug 7, 2024

changeset-bot bot commented Aug 7, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Aug 7, 2024 • edited Loading

codecov bot commented Aug 7, 2024 • edited Loading

Codecov Report

acao commented Aug 24, 2024

acao Aug 24, 2024

Choose a reason for hiding this comment

acao Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

acao Aug 24, 2024

Choose a reason for hiding this comment

acao Aug 24, 2024

Choose a reason for hiding this comment

changeset-bot bot commented Aug 7, 2024 •

edited

Loading

github-actions bot commented Aug 7, 2024 •

edited

Loading

codecov bot commented Aug 7, 2024 •

edited

Loading

acao Aug 24, 2024 •

edited

Loading