-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[graphiql/toolkit] support graphql-sse #3750
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2936a79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3750 +/- ##
==========================================
- Coverage 65.32% 64.93% -0.39%
==========================================
Files 122 123 +1
Lines 7003 7045 +42
Branches 2260 2252 -8
==========================================
Hits 4575 4575
- Misses 2411 2453 +42
Partials 17 17
|
The latest changes of this PR are available as canary in npm (based on the declared
|
const sseClient = createClient({ | ||
retryAttempts: 0, | ||
// @ts-expect-error | ||
singleConnection: true, // or use false if you have an HTTP/2 server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this supposed to be configured by the user? Does it not support distinct connections mode?
I'm having issues getting the client to send POST requests (distinct connections mode) instead of PUT requests (single connection mode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, we need to pass options in
const sseFetcher = await createSseFetcher({ | |
url: options.subscriptionUrl, | |
}); |
@dimaMachina can you update the docs in toolkit as well? |
@dimaMachina needs a very minor rebase it seems, main release branch is now unblocked! |
No description provided.