First draft for upgrade guide to v17 #4310
Conversation
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
|
|
||
| ## Removals | ||
|
|
||
| - Removed exported `getOperationType` function |
There was a problem hiding this comment.
| - Removed exported `getOperationType` function | |
| - Removed deprecated `getOperationType` function, use instead the `getRootType()` method on the | |
| appropriate `GraphQLSchema` object. |
| ## Removals | ||
|
|
||
| - Removed exported `getOperationType` function | ||
| - Removed exported `getVisitFn` function |
There was a problem hiding this comment.
| - Removed exported `getVisitFn` function | |
| - Removed deprecated `getVisitFn` function, use `getEnterLeaveForKind` instead. |
|
|
||
| - Removed exported `getOperationType` function | ||
| - Removed exported `getVisitFn` function | ||
| - Removed exported `printError` and `formatError` utilities |
There was a problem hiding this comment.
| - Removed exported `printError` and `formatError` utilities | |
| - Removed deprecated `printError` and `formatError` utilities, use instead the `toString` and `toJSON` methods on the desired `GraphQLError` object. |
| - Removed exported `getOperationType` function | ||
| - Removed exported `getVisitFn` function | ||
| - Removed exported `printError` and `formatError` utilities | ||
| - Removed exported `assertValidName` and `isValidNameError` utilities |
There was a problem hiding this comment.
| - Removed exported `assertValidName` and `isValidNameError` utilities | |
| - Removed deprecated `assertValidName` and `isValidNameError` utilities, convert to `assertName`. |
There was a problem hiding this comment.
Do we have a standard of doing empty braces? Feels a bit redundant
There was a problem hiding this comment.
removed, to each their own!
| - Removed exported `printError` and `formatError` utilities | ||
| - Removed exported `assertValidName` and `isValidNameError` utilities | ||
| - Removed exported `assertValidExecutionArguments` function | ||
| - Removed `getFieldDefFn` from `TypeInfo` |
There was a problem hiding this comment.
| - Removed `getFieldDefFn` from `TypeInfo` | |
| - Removed deprecated `getFieldDefFn` method from `TypeInfo`. If you really need to customize field resolution, you can subclass the `GraphQLSchema` class and override the `getField` method. |
There was a problem hiding this comment.
I would heavily avoid subjective strengtheners like truly
There was a problem hiding this comment.
I switched it to the "if you really need this" construction used elsewhere
| - Removed exported `assertValidName` and `isValidNameError` utilities | ||
| - Removed exported `assertValidExecutionArguments` function | ||
| - Removed `getFieldDefFn` from `TypeInfo` | ||
| - Removed `TypeInfo` from `validate` https://github.com/graphql/graphql-js/pull/4187 |
There was a problem hiding this comment.
| - Removed `TypeInfo` from `validate` https://github.com/graphql/graphql-js/pull/4187 | |
| - Removed deprecated `TypeInfo` argument from `validate`, this was previously used to support non-specified validation behavior that is explicitly discouraged; custom behavior can be better obtained by using custom rules. |
I removed the reference to the PR which has no additional info, and we didn't link to PRs generally, but it's fine really to keep.
There was a problem hiding this comment.
I mean, the PR's having no context is its own issue. You're right though, none of the PR's give the context we require to pick all of this up. Not sure whether we need to specify whether it was deprecated though, I don't think that matters at all
There was a problem hiding this comment.
The advantage of sprinkling the word deprecating in is that it hopefully gives the reader the (correct) understanding that although the list of breaking changes may be lengthy, it is shorter if they are not using deprecated functionality. This might be immediately helpful to those who know that they are not using deprecated functionality and might encourage those still using deprecated functionality to migrate off of it if they have not done so. I have changed elsewhere exported to deprecated as a one word change that gives this impression as a whole. Here I am adding the one word for consistency.
In terms of the no context on the linked PR, that is certainly my bad as it is mine, I take that constructive criticism, will try to improve in the future. I have edited suggestion above to give more context inline.
| - Removed exported `getVisitFn` function | ||
| - Removed exported `printError` and `formatError` utilities | ||
| - Removed exported `assertValidName` and `isValidNameError` utilities | ||
| - Removed exported `assertValidExecutionArguments` function |
There was a problem hiding this comment.
| - Removed exported `assertValidExecutionArguments` function | |
| - Removed deprecated function `assertValidExecutionArguments()` function, use `assertValidSchema()` to validate the schema. |
There was a problem hiding this comment.
We haven't actually deprecated this in v16 I think, I will submit a PR to do this. All the additional checks in that function are now just performed by TS.
|
@JoviDeCroock I have started working on merging in what I have been tracking in #4198 ... these are a few suggestions so far, let me know if you'd rather have me open up PRs to this PR rather than do it like this. |
No description provided.