fix: native BarocdeDetector doesn't support requested formats
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vue-qrcode-reader with
|
| Latest commit: |
575df0d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e4fbbda9.vue-qrcode-reader.pages.dev |
| Branch Preview URL: | https://check-supported-barcode-form.vue-qrcode-reader.pages.dev |
|
@wosiwq Can you go to either one of these preview URLs above and check if this works for you? |
Previously we always used the native `BarocdeDetector` implementation if available. However, the native API might be available but does not support the barcode formats requested by the user. For example, `"qr_code"` might be supported but the user wants to scan `["qr_code", "aztec"]`. In these cases, we now also fallback to the polyfill implementation. Closes #450
gruhn
force-pushed
the
check-supported-barcode-formats
branch
from
5fd0f9c
to
e7efc03
Compare
|
apologize for getting back to you so late due to the time zone, after my testing this version works fine in my environment. #450 is no longer the case |
wosiwq
suggested changes
Sep 20, 2024
|
🎉 This PR is included in version 5.5.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always used the native
BarocdeDetectorimplementation if available. However, the native API might be available but does not support the barcode formats requested by the user. For example,"qr_code"might be supported but the user wants to scan["qr_code", "aztec"]. In these cases, we now also fallback to the polyfill implementation.Closes #450