Update from nopt 4.x to nopt 5.0.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installation of latest [email protected] produces a warning: ``` npm WARN deprecated [email protected]: This package is no longer supported. ``` This package is only used by nopt to call `os.homedir()` which has been stable since Node.js 2. It was removed [1] in nopt 5.0.0. There are newer versions of nopt available, but those raise the required Node.js engine level. In order to make this easy to release and to resolve the warning first, let's first move to nopt 5.0.0. [1]: npm/nopt@5c0e45b
|
I still notice the warning, are you sure it comes from nopt? https://github.com/gruntjs/grunt-cli/actions/runs/9440385892/job/25999608376?pr=156#step:4:10 |
|
@XhmikosR Yes and no. Yes, when using this e.g. in wikimedia/mediawiki, this is the only package pulling it in. "node_modules/grunt-cli/node_modules/nopt": {
"version": "4.0.3",
…,
"dependencies": {
…,
"osenv": "^0.1.4"
},
…
"grunt-cli": {
"version": "1.4.3",
…,
"requires": {
…,
"nopt": "~4.0.1",
…
},
"dependencies": {
"nopt": {
"version": "4.0.3",
…,
"requires": {
…,
"osenv": "^0.1.4"I believe this PR would fix the warning for downstream users of Grunt. But, my guess is that there is a dev dependency within the grunt-cli repo that is still pulling it in by other means as well. |
|
OK. It's actually grunt 1.6.1, also depending on the even older |
|
All good, I just noticed it on CI and thought I'd mention it :) |
Krinkle
added a commit
to Krinkle/grunt
that referenced
this pull request
Jul 20, 2024
* grunt-cli updated to nopt 4.x in gruntjs/grunt-cli#117 * grunt-cli updated to nopt 5.0 in gruntjs/grunt-cli#156 * changelog: https://github.com/npm/nopt/blob/v5.0.0/CHANGELOG.md The simple usage of `nopt(known, alias, argv, 2)` has remained unchanged through both changes, same as in this repo. Installation of latest grunt- produces a warning: > npm WARN deprecated [email protected]: This package is no longer supported. This package was used by nopt to call `os.homedir()` which has been built-in since Node.js 2. The dependency was removed in nopt 5.0.0 with npm/nopt@5c0e45b. Newer versions of nopt are available, but those raise the required Node.js engine level. In order to make this safe to land, and easy to release, resolve the warning first by moving to nopt 5.0.0, matching grunt-cli. I'm loosening grunt-cli to allow for grunt-cli 1.5.0, which was just released with a similar fix. This way it will update by default, but not cause duplicate installations for downstream projects that depend on grunt-cli 1.4 directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installation of latest [email protected] produces a warning:
This package is only used by nopt to call
os.homedir()which has been stable since Node.js 2. It was removed npm/nopt@5c0e45b in nopt 5.0.0.There are newer versions of nopt available, but those raise the required Node.js engine level. In order to make this safe to land, and easy to release, resolve the warning first by moving to nopt 5.0.0.