fix(loadNpmTasks): load tasks relative to package location #1762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vladikoff
Fixes #1732
Implements @tehhowch suggested to fix to support symlinked npm packages within a mono-repo setting. Existing tests pass and I was able to test this within a local mono-repo myself. I'm not sure how to add a new test with a symlink so I'm making an assumption that if existing tests pass, then this is ok.
I also had to fix a special case where if an npm package's tasks are not loaded at the package root (e.g. not
node_modules/foo/tasks
instead atnode_modules/foo/dist/tasks
), then parse the directory name and include that when loading the tasks.For example:
grunt.loadNpmTasks('grunt-contrib-clean')
-> Would check fortasks
directory at package root.grunt.loadNpmTasks('@foo/grunt-bar')
-> Would also check fortasks
directory at package root.grunt.loadNpmTasks('@foo/grunt-bar/dist')
-> Would add thedist
directory to check for the tasksPlease let me know of another way if possible.