-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to select/unselect all files #2187
Conversation
@@ -63,6 +63,7 @@ work. If not, see <https://creativecommons.org/publicdomain/zero/1.0/>. | |||
<string name="last_modified">Last modified</string> | |||
<string name="select_this_folder">Select this folder</string> | |||
<string name="select">Select</string> | |||
<string name="select_all">Select all</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the button title should change to 'clear' if all items are selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better yet we can do the following:
- If no items selected make the text
Select all
- If one or more items selected make the text
Clear (n)
where n is the number of items selected
Then we don't need to modify the title to add a clear button etc. Changes become much simpler
I added several related improvements in #2176 (currently open PR). These changes are
This PR is more complete. So I think it makes sense for me to remove the clear button I added and instead use this. I will keep my underlying changes. @guanglinn @gsantner I think this should be merged in first and then I will make the requisite changes to my PR |
I agree with you, doing so can be better to improve this feature. |
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java
Outdated
Show resolved
Hide resolved
Thank you, I'm merging this. As noted, "clear all" is something we want too, but harshad has some things in the works anyway about the selection. So lets make this simple one as first 😄 |
I have reworked this in my PR #2200 Here is what it looks like now:
|
Nice, I should try it. |
Add options to select/unselect all files, now do some file operations more conveniently in Markor.