Make headline dialog work in view mode #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headline-dialog-in-view-mode.mp4 |
|
Nice. How do you have rounded dialog corners though? |
harshad1
reviewed
Jan 21, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Outdated
Show resolved
Hide resolved
harshad1
reviewed
Jan 21, 2024
This is my old device which was flashed a custom ROM crDroid, I guess this ROM modified the style of the dialog. Anyway, it does look much better. |
|
conflicts |
added 6 commits
February 16, 2024 21:15
# Conflicts: # app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java # app/src/main/java/net/gsantner/markor/format/ActionButtonBase.java
|
@gsantner . Conflicts has been resolved, it is ready to be merged now. |
gsantner
approved these changes
Mar 27, 2024
|
Had been looking forward to this moment for a long time! 😄 |
|
Thanks for help, and your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the headline dialog work in view mode. This feature could meet the requirements in the suggestions from PR #2190.