-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fast scroll for file browser #2213
Conversation
scrollbar-file-browser.mp4 |
So we have these classes already: Perhaps we should just repurpose this logic? |
Thank you for your prompt. These codes are very useful and I should reuse them. I may need to override RecyclerView. |
But the RecyclerView already has built-in fast scroll, and I have used it, it works well. Is it necessary to override this class? This may cause redundant code. I think it may be unnecessary. |
Ok. Just wanted to show you that code in case it makes sense to reuse it. If it does not then it does not |
Thanks for your guidance, which lets me have a better understanding of this project's code. |
Hi, @gsantner . Do you prefer hex color values in lowercase or uppercase. |
I prefer uppercase for hexdecimal. But there is no need to refactor any predefined colors when they are not upper.
|
…scrollbar # Conflicts: # app/src/main/res/values/colors.xml
This PR is ready to be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the scroll track works as expected.
Though - @harshad1 @guanglinn : the scrolling feel s very sluggish now. There were a lot of changes to the scrolling including i.e. threadexecutor, which might be an delay/sync issue. It feels quite bad 😄
@guanglinn Also another finding, the file/folder blinks when browsing files. I.e. go to subfolder and up again, and the file is highlighted again and again. |
@gsantner I will try to resolve these issues as soon as possible. |
Some impressions screen-20240329-004203.mp4screen-20240329-003534.mp4 |
Thank you very much for implementing (and wanting to improve it) |
Enable fast scroll for RecyclerView, the scrollbar will also be revealed in the file browser.