Feature choose language #22
Conversation
|
I don't know if this is the best way to have the translations, I was thinking of leaving the translations out of the python package to keep the package smaller and if the user wants a specific translation, the CLI would download the translation and put it inside the folder of configuration. Today we only have two languages, but in the future we may have several and this can increase the size of the package and not everyone needs to have all the translations by default. What do you think? |
|
To fix the linting you can run the |
|
Yeah, I think it is better to keep it to a minimum, so can we continue with my PR for the moment which is 2 languages (i am fixed the linting), and start looking for an option to increase the number of languages? |
|
I think it's better to do the final solution to avoid problems with future versions. I thought of having a folder called translations at the root of the project and inside it containing the folders or just the files with the translated quotes. In the CLI, have a command that lists the possible translations and downloads from this location to the config folder of the PLS-CLI and configures the default language within the configuration file. |
pls_cli/please.py
Outdated
| @@ -142,16 +142,16 @@ def language(lang: str) -> None: | |||
| else: | |||
| settings['language'] = lang | |||
| Settings().write_settings(settings) | |||
| # Here function Dowload quotes | |||
|
|
|||
| # Here function Dowload quotes | |||
There was a problem hiding this comment.
@guedesfelipe i am reformat the code, the download part would go here, but i really don't have much idea how to query the current branch to be able to download the quotes, can you give me a hint?
There was a problem hiding this comment.
Sure! I will take a look at the code and help you with that as soon as possible
There was a problem hiding this comment.
Sorry for the delay, I was busy these days and I still haven't been able to make an example code, but I was thinking of doing the part of downloading the translated files like this:
https://github.com/Textualize/rich/blob/master/examples/downloader.py
Or with Requests library...
|
-💡Moved quotes location |
pls_cli/please.py
Outdated
| @@ -131,6 +131,70 @@ def quotes(show: bool = True) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| @app.command('language', rich_help_panel='Utils and Configs') | |||
There was a problem hiding this comment.
Here I suggest to using enum, like this:
https://typer.tiangolo.com/tutorial/parameter-types/enum/
There was a problem hiding this comment.
That was a better solution, it's already updated 👨💻
| @@ -131,6 +132,45 @@ def quotes(show: bool = True) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| class language(str, Enum): | |||
| english = "english" | |||
There was a problem hiding this comment.
I think it's better to use the short form, like en for english and es for spanish, what do you think?
| ) -> None: | ||
| """Choose language 🛩️""" | ||
| settings = Settings().get_settings() | ||
| if settings["language"] == lang: |
There was a problem hiding this comment.
here it would be better to have just an if with the comparison of different. And in the end have only one center_print to avoid code duplication, like this:
if settings["language"] != lang:
settings["language"] = lang
Settings().write_settings(settings)
# Here function Dowload quotes
center_print(
Rule(
"Thanks for letting me know that!",
style=insert_or_delete_line_style,
),
style=insert_or_delete_text_style,
)
cener_print(
Rule(
f"Current language is: {lang}",
style=insert_or_delete_line_style,
),
style=insert_or_delete_text_style,
)| @@ -481,6 +521,18 @@ def setup() -> None: | |||
| ) | |||
| console.print(code_markdown) | |||
|
|
|||
| code_markdown = Markdown( | |||
| """ | |||
| pls language --lang <language> | |||
There was a problem hiding this comment.
Here is correct? pls language --lang <language>
This issue added in doc #21
I tried to copy as much as possible to your coding/commit style, I await your comments 👀