Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check modules before adding base meta modules #249

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

meteyou
Copy link
Contributor

@meteyou meteyou commented Feb 12, 2025

This PR just add a condition before adding base meta modules. It just checks if the module exists, before adding it.

@guysoft
Copy link
Owner

guysoft commented Feb 13, 2025

Why are you doing this?
I am asking because

  1. I want to know what flow is breaking for you, if any
  2. These moduels are remote modules, their path is different and they are not in the DIST_PATH. They are retrieved like this:
    https://github.com/guysoft/CustomPiOS/wiki/Modules#remote-modules

@meteyou
Copy link
Contributor Author

meteyou commented Feb 13, 2025

i just had issues to build images, because i got the error message, that the module was not found.

just my 2 cents: i don't like a system, which just adds modules and I don't know it... I would prefer to add modules myself, instead "auto hidden added modules".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants