Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is Pr #240 with unit testing #251

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

guysoft
Copy link
Owner

@guysoft guysoft commented Feb 22, 2025

May not be merged, see talk in #240

@guysoft guysoft force-pushed the feature/unit-testing-with-pr240 branch from c2296ef to 913e384 Compare February 22, 2025 22:18
@jxmx
Copy link
Contributor

jxmx commented Feb 23, 2025

I ran your unit test but I fail to see what the unit test has to do with the proposed changes. Nothing about the unit test seems to be using common.sh?

@guysoft
Copy link
Owner Author

guysoft commented Feb 24, 2025

I ran your unit test but I fail to see what the unit test has to do with the proposed changes. Nothing about the unit test seems to be using common.sh?
Start of line of test_qemu_setup.sh

DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
# Source the main script
source "${DIR}"/../src/common.sh

Then you can see plenty of uses of chroot_correct_qemu which is now part of common.sh

@jxmx
Copy link
Contributor

jxmx commented Feb 26, 2025

I added a test for "debian" and it looks okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants