Update links to source code, fix heading levels #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
commented
Aug 3, 2024
| @@ -43,30 +43,30 @@ You build and run LogExample the same way you would build and run any of the oth | |||
|
|
|||
| [](images/LoggingExample.png) | |||
|
|
|||
| LogExample is configured using [`LogExample.gwt.xml`](https://gwt.googlesource.com/gwt/+/master/samples/logexample/src/com/google/gwt/sample/logexample/LogExample.gwt.xml). | |||
There was a problem hiding this comment.
Links are dead since gwtproject/gwt@54908f2
There was a problem hiding this comment.
Probably should phase this out entirely, update the doc with what is expected instead of linking to a defunct example (in a later commit)
zbynek
commented
Aug 3, 2024
| @@ -61,7 +61,7 @@ Google App Engine Datastore. In persistence frameworks like JDO and JPA, | |||
| entities are annotated with @Entity. RequestFactory does not require the use of | |||
| any particular framework or annotations on your domain classes. Here's part of | |||
| an entity definition from the [Expenses | |||
There was a problem hiding this comment.
Dead since gwtproject/gwt@1154b2c
|
Preview at https://netlify--gwtproject-preview.netlify.app/ (also contains gwtproject/gwt-site-webapp#13) |
niloc132
approved these changes
Nov 12, 2024
| @@ -43,30 +43,30 @@ You build and run LogExample the same way you would build and run any of the oth | |||
|
|
|||
| [](images/LoggingExample.png) | |||
|
|
|||
| LogExample is configured using [`LogExample.gwt.xml`](https://gwt.googlesource.com/gwt/+/master/samples/logexample/src/com/google/gwt/sample/logexample/LogExample.gwt.xml). | |||
There was a problem hiding this comment.
Probably should phase this out entirely, update the doc with what is expected instead of linking to a defunct example (in a later commit)
|
(commented on the wrong PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "edit on GitHub" link is not positioned correctly on pages that use
<h2>instead of<h1>and it points to a wrong branch.While fixing that, I also updated some links that point to googlesource and should point to GH.