Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention source file name for JDT parsing exceptions #10093

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

zbynek
Copy link
Collaborator

@zbynek zbynek commented Feb 15, 2025

If JDT fails to parse a file, the thrown exception can be very cryptic. This at least adds the name of the source unit to the thrown exception.

@zbynek zbynek force-pushed the wrap-jdt-exception branch from 4ca094b to 85f5f32 Compare February 15, 2025 21:56
@niloc132
Copy link
Member

Do you have an example stack trace that can cause this situation today?

@zbynek
Copy link
Collaborator Author

zbynek commented Feb 16, 2025

[ERROR] Unexpected internal compiler error
java.lang.ArrayIndexOutOfBoundsException: Index 922 out of bounds for length 870
        at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13147)
        at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13404)
        at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13361)
        at com.google.gwt.dev.javac.JdtCompiler$ParserImpl.parse(JdtCompiler.java:204)
        at org.eclipse.jdt.internal.compiler.parser.Parser.dietParse(Parser.java:11747)
        at org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:851)
        at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:394)
        at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:444)
        at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:426)
        at com.google.gwt.dev.javac.JdtCompiler.doCompile(JdtCompiler.java:1021)
        at com.google.gwt.dev.javac.CompilationStateBuilder$CompileMoreLater.compile(CompilationStateBuilder.java:322)
        at com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:532)
        at com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:464)
        at com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:426)
        at com.google.gwt.dev.Precompile.precompile(Precompile.java:210)
        at com.google.gwt.dev.Precompile.precompile(Precompile.java:190)
        at com.google.gwt.dev.Precompile.precompile(Precompile.java:131)
        at com.google.gwt.dev.Compiler.compile(Compiler.java:192)
        at com.google.gwt.dev.Compiler.compile(Compiler.java:143)
        at com.google.gwt.dev.Compiler.compile(Compiler.java:132)
        at com.google.gwt.dev.Compiler$1.run(Compiler.java:110)
        at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:55)
        at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRunner.java:50)
        at com.google.gwt.dev.Compiler.main(Compiler.java:113)

observed when all transitive dpendencies of gwt-dev are added to GWT classpath, I assume that's because it makes JDT 3.19 take over (#10082 (review))

@niloc132 niloc132 merged commit 32a0771 into gwtproject:main Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants