Remove deprecated or internal types, mark unused code deprecated #9925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnehlmeier
approved these changes
Aug 15, 2024
|
Agreed, though I'm loathe to write more ant build files if we can help it - far rather finish converting to cleaner source directories and then as we need to write packaging code for building gwt-user/dev/servlet artifacts, also make this fit into that mold. |
niloc132
force-pushed
the
9923-deprecation
branch
from
86f9e47
to
39218db
Compare
vegegoku
reviewed
Oct 10, 2024
| @@ -22,6 +22,7 @@ | |||
| /** | |||
| * Tree logger that logs servlet context information. | |||
| */ | |||
There was a problem hiding this comment.
Do you think we need to add a doc for deprecation reason and the replacement if there is any?
vegegoku
approved these changes
Oct 10, 2024
vegegoku
approved these changes
Oct 15, 2024
niloc132
added a commit
to niloc132/gwt
that referenced
this pull request
Oct 15, 2024
niloc132
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9923
Fixes #9921