-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile removed Eduardo De La Rosa from leadership in Home Unite Us #7880
base: gh-pages
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: M, W, F |
Hi @Eddysunday012! I just merged an older PR that changed this file and it created a conflict. Please pull the |
Thank you for letting me know @LRenDO ! I just updated and pushed my local branch with the PR you merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eddysunday012, thank you for working on this issue!
Checklist:
- Step 0: PR is done with the correct branch.
- Step 1: PR links to the correct issue Update Project Profile: Home Unite Us Remove Eduardo De La Rosa #7479
- Step 2: Changes address the issue action items.
- Step 3: Home Unite Us page looks good on the browser.
- Step 4: Source code changes look good.
- Correct file and variable updated
- Step 5: No other issues seen.
PR is approved, well done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eddysunday012, thank you for working on this issue. Everything looks good. Great work!
- PR is done with the correct branch.
- The correct issue is linked.
- The correct member is removed.
- The Home Unite Us page displays correctly on browser, iPad, and iPhone (chrome).
- Code changes align with the issue requirements.
- No additional issues introduced.
Review ETA: EOD 2/6/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Eddysunday012, thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- CodeQL Alerts have been properly checked.
- Before and after screenshots are appropriately included.
- PR follows correct format and is properly written.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
- Source code changes are applicable and clean.
Suggested changes:
- None
Notes:
- Backticks (`) can be used to format short snippets of code.
Thank you for your hard work @Eddysunday012, I approve this PR.
Fixes #7479
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied