Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jar-file.md #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update jar-file.md #492

wants to merge 1 commit into from

Conversation

Xiai24
Copy link

@Xiai24 Xiai24 commented Mar 17, 2025

修改错别字，对execStart添加解释

@Xiai24
Update jar-file.md
ab8d143 
修改错别字，对execStart添加解释
@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 4:46am

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 17, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 17, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby March 17, 2025 04:44
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ruibaby
ruibaby requested changes Mar 17, 2025
View reviewed changes
versioned_docs/version-2.20/getting-started/install/jar-file.md

[Install]
WantedBy=multi-user.target
```

- **ExecStart**: java的真实存在地址，就像java包下bin目录中的java，假如自己的java没有安装在这个位置，需要修改
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我认为没有必要再添加这个描述，并且 ExecStart 是完整的命令，不只是需要说明 java bin 的路径问题。

此外，在底部已经有了关于 java bin 的说明。

https://docs.halo.run/getting-started/install/jar-file#:~:text=User%3DUSER%E3%80%82-,%E6%8F%90%E7%A4%BA,-%E8%AF%B7%E7%A1%AE%E4%BF%9D%20/usr

@ruibaby
Copy link
Member

ruibaby commented Mar 17, 2025

还需要同时修改 https://github.com/halo-dev/docs/blob/main/docs/getting-started/install/jar-file.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby requested changes

@guqing guqing Awaiting requested review from guqing

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xiai24 @ruibaby