Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pending problem of requesting console and uc pages in dev mode #7281

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR fixes the pending problem of requesting console and ui pages in dev mode.

Which issue(s) this PR fixes:

Fixes #7191

Special notes for your reviewer:

Steps to reproduce:

  • Start ui projects with dev mode by executing command make -C ui dev.
  • Run Halo instance in dev mode by executing command ./gradlew bootRun --args="--spring.profiles.active=dev".
  • Try to request http://localhost:8090/uc and http://localhost:8090/console.
  • Try to refresh page by hand and see the result

Does this PR introduce a user-facing change?

修复开发模式下无法正常进入管理和个人中心页面的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 10, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Mar 10, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 10, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen March 10, 2025 07:47
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (eff73dc) to head (64a6c68).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/run/halo/app/infra/console/ProxyFilter.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7281      +/-   ##
============================================
+ Coverage     56.99%   57.11%   +0.11%     
- Complexity     3999     4055      +56     
============================================
  Files           714      721       +7     
  Lines         24110    24474     +364     
  Branches       1585     1613      +28     
============================================
+ Hits          13742    13978     +236     
- Misses         9756     9871     +115     
- Partials        612      625      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
Copy link

f2c-ci-robot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit ddbbe09 into halo-dev:main Mar 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console页面和uc页面刷新问题
2 participants