Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for addColumns with various address mapping policies #1028

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jul 11, 2022

Context

TBP

How has this been tested?

TBP

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature or improvement (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Additional language file or change to the existing one (translations)
  • Change to the documentation

Related issues:

  1. addColumns throws an error with AlwaysDense address mapping with empty values #1027

Checklist:

  • My code follows the code style of this project.
  • I described the modification in the CHANGELOG.md file.
  • My change requires a change to the documentation.
  • My change requires a migration guide.

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Performance comparison of head (1b9d4b9) vs base (419d776)

                                     testName |  base |  head |   change
------------------------------------------------------------------------
                                      Sheet A | 601.3 | 592.9 |   -1.40%
                                      Sheet B | 252.3 | 255.9 |   +1.43%
                                      Sheet T | 296.8 | 283.3 |   -4.55%
                                Column ranges | 619.8 | 663.1 |   +6.99%
Sheet A:  change value, add/remove row/column |    34 |    38 |  +11.76%
 Sheet B: change value, add/remove row/column |   333 |   367 |  +10.21%
                   Column ranges - add column |   199 |   435 | +118.59%
                Column ranges - without batch |   706 |   624 |  -11.61%
                        Column ranges - batch |   187 |   332 |  +77.54%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant