Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of precisionRounding to 10 #1456

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Nov 6, 2024

Context

  • Set default value of precisionRounding to 10
  • Adjust the reference for the precisionRounding configuration option
  • Mention the limitations of the JavaScript floating-point arithmetic in the specifications-and-limits guide and reference the precisionRounding there
  • Adjust unit tests
  • Add changelog entry
  • Add migration guide

How did you test your changes?

  • unit tests pass
  • local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1300

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba added the Breaking Change Will need a major release label Nov 6, 2024
@sequba sequba self-assigned this Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Performance comparison of head (9144ac2) vs base (4ca2f87)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 512.07 | 504.21 | -1.53%
                                      Sheet B |  163.2 | 167.84 | +2.84%
                                      Sheet T | 144.05 | 144.11 | +0.04%
                                Column ranges | 505.99 | 506.51 | +0.10%
Sheet A:  change value, add/remove row/column |  14.13 |   14.6 | +3.33%
 Sheet B: change value, add/remove row/column |  126.1 | 126.38 | +0.22%
                   Column ranges - add column |  150.5 | 152.93 | +1.61%
                Column ranges - without batch | 421.76 | 456.94 | +8.34%
                        Column ranges - batch | 106.91 |  114.9 | +7.47%

@sequba sequba requested review from budnix and removed request for budnix November 6, 2024 17:47
@sequba sequba merged commit 2a5cd84 into develop Nov 13, 2024
21 of 22 checks passed
@sequba sequba deleted the feature/issue-1300 branch November 13, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Will need a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The precisionRounding: 14 causes the =200.05 - 200 equation to print 0.0500000000000114 instead of 0.05
2 participants