Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signatures of simpleCellAddressToString and simpleCellRangeToString #1457

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Nov 7, 2024

Context

  • simpleCellAddressToString
    • change signature
    • change implementation
    • update unit tests
    • update documentation
  • simpleCellRangeToString
    • change signature
    • change implementation
    • update unit tests
    • update documentation
  • simpleCellAddressFromString
    • improve documentation
  • simpleCellRangeFromString
    • improve unit tests
    • improve documentation
  • add changelog entry

image
image
image
image

How did you test your changes?

  • unit tests pass
  • new unit tests
  • local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1151

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

Copy link

github-actions bot commented Nov 7, 2024

Performance comparison of head (bcefb40) vs base (c27a9d5)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 517.53 | 517.88 | +0.07%
                                      Sheet B | 172.08 | 169.95 | -1.24%
                                      Sheet T | 149.47 | 150.08 | +0.41%
                                Column ranges | 517.04 | 523.25 | +1.20%
Sheet A:  change value, add/remove row/column |  15.38 |  15.31 | -0.46%
 Sheet B: change value, add/remove row/column | 142.29 | 140.67 | -1.14%
                   Column ranges - add column | 163.28 | 160.25 | -1.86%
                Column ranges - without batch | 479.48 | 463.14 | -3.41%
                        Column ranges - batch | 121.52 | 118.66 | -2.35%

Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some small suggestions.

src/HyperFormula.ts Outdated Show resolved Hide resolved
src/HyperFormula.ts Outdated Show resolved Hide resolved
sequba and others added 2 commits November 13, 2024 10:18
Co-authored-by: Krzysztof ‘Budzio’ Budnik <[email protected]>
Co-authored-by: Krzysztof ‘Budzio’ Budnik <[email protected]>
@sequba sequba merged commit 4ca2f87 into develop Nov 13, 2024
21 of 22 checks passed
@sequba sequba deleted the feature/issue-1151 branch November 13, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make signatures of simpleCellAddressToString and simpleCellRangeToString more logical
2 participants