Feature/foreground service #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesa2
force-pushed
the
feature/foregroundSservice
branch
from
5f4fdc5 to
7162bb2
Compare
Signed-off-by: MGasztold <[email protected]>
Signed-off-by: MGasztold <[email protected]>
Signed-off-by: MGasztold <[email protected]>
Signed-off-by: MGasztold <[email protected]>
…because app is in background
hannesa2
force-pushed
the
feature/foregroundSservice
branch
from
7162bb2 to
902fb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-paho/paho.mqtt.android#418
This pull requests solves issues with Android versions >=8 in which service is killed by OS when app is in background or after screen is turned off. The price to pay for this is the notification that has to be permanently visible in the app's status bar.
The API I proposed let's developer start MQTT service as foreground service and provide its own Notification object. In the same time it is totally optional.
I also got rid of legacy support library dependency in favor of latest androidx dependency.
This pull requests tries to solve the following issues:
#416 #332 #281 #274 #226