6295 chain search params for auth filtering #6300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2024 16:48
|
This Pull Request has failed the formatting check Please run You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling |
| IAuthorizationSearchParamMatcher.MatchResult mr = matcher.match( | ||
| theRuleTestRequest.resource.fhirType() + "?" + myQueryParameters, theRuleTestRequest.resource); | ||
| new IAuthorizationSearchParamMatcher.AuthSearchMatchParameters().setQueryParameters(theRuleTestRequest.resource.fhirType() + "?" + myQueryParameters) |
There was a problem hiding this comment.
minor: I doubt we need a request object for Resource + query string.
| @@ -44,7 +44,7 @@ public boolean matchesOutput(RuleTestRequest theRuleTestRequest) { | |||
|
|
|||
| private boolean checkMatch(RuleTestRequest theRuleTestRequest) { | |||
| // look for a matcher | |||
| IAuthorizationSearchParamMatcher matcher = theRuleTestRequest.ruleApplier.getSearchParamMatcher(); | |||
There was a problem hiding this comment.
suggestion: The SearchParamMatcher interface is fine. so how about we limit the changes within/under that api. No changes should be required in the rules package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.