Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rancher/shell to 3.0.2-rc6 #206

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Mar 14, 2025

Summary

  • Upgrade rancher/shell to 3.0.2-rc6
  • Fix missing content in delete VM modal.

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#7768

Test screenshot/video

Screenshot 2025-03-14 at 4 16 18 PM image

Extra technical notes summary

@a110605 a110605 requested review from torchiaf and houhoucoop March 14, 2025 08:26
@a110605 a110605 self-assigned this Mar 14, 2025
@a110605 a110605 changed the title upgrade rancher/shell to 3.0.2-rc6 Upgrade rancher/shell to 3.0.2-rc6 Mar 14, 2025
@@ -69,12 +67,6 @@ export default {

return out;
},

plusMore() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow with https://github.com/rancher/dashboard/pull/13456/files to remove plusMore().

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 2dff7b0 into harvester:main Mar 14, 2025
3 checks passed
mergify bot pushed a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Andy Lee <[email protected]>
(cherry picked from commit 2dff7b0)
a110605 added a commit that referenced this pull request Mar 14, 2025
Signed-off-by: Andy Lee <[email protected]>
(cherry picked from commit 2dff7b0)

Co-authored-by: Andy Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants