Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doneOverride path for harvesterhci.io.virtualmachinetemplate #211

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Mar 19, 2025

Summary

The page redirect to https://localhost:8005/harvester/c/local/harvesterhci.io.virtualmachinetemplate after deleting a VM template which gets a strange table layout.

It should back to the same page https://localhost:8005/harvester/c/local/harvesterhci.io.virtualmachinetemplateversion.

before-fix.mov

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

Test screenshot/video

fix-after.mov

Extra technical notes summary

@a110605 a110605 requested review from torchiaf and houhoucoop March 19, 2025 09:59
@a110605 a110605 self-assigned this Mar 19, 2025
@a110605 a110605 changed the title fix the doneOverride path for harvesterhci.io.virtualmachinetemplate Fix doneOverride path for harvesterhci.io.virtualmachinetemplate Mar 19, 2025
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 22a032e into harvester:main Mar 20, 2025
3 checks passed
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
a110605 added a commit that referenced this pull request Mar 20, 2025
…211) (#213)

Signed-off-by: Andy Lee <[email protected]>
(cherry picked from commit 22a032e)

Co-authored-by: Andy Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants