Skip to content

Commit

Permalink
update legacy Dockerfile to use knesset-data-python from git master
Browse files Browse the repository at this point in the history
  • Loading branch information
OriHoch committed Sep 29, 2024
1 parent 31883ab commit 185d5d9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ FROM ghcr.io/hasadna/knesset-data-pipelines/knesset-data-pipelines:8028b98004108
#COPY Pipfile.lock /pipelines/
#RUN pipenv install --system --deploy --ignore-pipfile
#RUN python3 -m pip install jupyterlab
RUN pip install -e 'git+https://github.com/hasadna/knesset-data-python.git@3e3141ff76eabf20a72d16fc098544759f5952a8#egg=knesset-data'
RUN pip uninstall -y knesset-data &&\
pip install -e 'git+https://github.com/hasadna/knesset-data-python.git@3e3141ff76eabf20a72d16fc098544759f5952a8#egg=knesset-data'
COPY datapackage_pipelines_knesset /pipelines/datapackage_pipelines_knesset
COPY setup.py /pipelines/
RUN pip install -e .
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Install Docker for [Windows](https://store.docker.com/editions/community/docker-
Pull the latest Docker image

```
docker pull orihoch/knesset-data-pipelines
docker pull ghcr.io/hasadna/knesset-data-pipelines/knesset-data-pipelines-legacy
```

#### Run Jupyter Lab
Expand All @@ -36,7 +36,7 @@ Start the Jupyter lab server:
```
docker run -it -p 8888:8888 --entrypoint jupyter \
-v /opt/knesset-data-pipelines:/pipelines \
orihoch/knesset-data-pipelines lab --allow-root --ip 0.0.0.0 --no-browser \
ghcr.io/hasadna/knesset-data-pipelines/knesset-data-pipelines-legacy lab --allow-root --ip 0.0.0.0 --no-browser \
--NotebookApp.token= --NotebookApp.custom_display_url=http://localhost:8888/
```

Expand Down Expand Up @@ -75,7 +75,7 @@ Run with Docker, mounting the local directory
```
docker run -it -p 8888:8888 --entrypoint jupyter \
-v `pwd`:/pipelines \
orihoch/knesset-data-pipelines lab --allow-root --ip 0.0.0.0 --no-browser \
ghcr.io/hasadna/knesset-data-pipelines/knesset-data-pipelines-legacy lab --allow-root --ip 0.0.0.0 --no-browser \
--NotebookApp.token= --NotebookApp.custom_display_url=http://localhost:8888/
```

Expand Down

0 comments on commit 185d5d9

Please sign in to comment.