Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top-level endpoints package containing AWS partition and Region metadata #1176

Merged
merged 16 commits into from
Sep 18, 2024
Merged

Add top-level endpoints package containing AWS partition and Region metadata #1176

merged 16 commits into from
Sep 18, 2024

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Generates AWS partition and Region metadata from AWS SDK for Go v2.
Adds querying functionality similar to AWS SDK for Go v1.

Closes #120.
Closes #649.

@ewbankkit ewbankkit requested a review from a team as a code owner September 17, 2024 19:11
jar-b
jar-b approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

endpoints/partition_test.go Show resolved Hide resolved
@ewbankkit ewbankkit merged commit 11f5f9c into main Sep 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison left review comments

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export AWS partitions and regions as Go constants Generate region data from AWS SDK data
3 participants
@ewbankkit @gdavison @jar-b