Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DebugLogging parameter from awsbase.Config and always enable logging #97

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Remove DebugLogging parameter from awsbase.Config and always enable logging #97

merged 1 commit into from
Feb 2, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 2, 2022

Terraform handles log levels, so request/response logging should always be enabled

Closes #96

@gdavison gdavison requested a review from a team as a code owner February 2, 2022 07:53
ewbankkit
ewbankkit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok      github.com/hashicorp/aws-sdk-go-base/v2 6.757s

@gdavison gdavison merged commit 39f6626 into v2 Feb 2, 2022
@gdavison gdavison deleted the always-log branch February 2, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit